Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MastodonMap TS type #24807

Merged
merged 1 commit into from
May 3, 2023

Conversation

renchap
Copy link
Sponsor Member

@renchap renchap commented May 3, 2023

Accounts are initialized using fromJS in reducers/accounts.js, which created an ImmutableJS Record, so let's use the proper type.

return state.set(account.id, fromJS(account));

@takayamaki can you please review?

This is initialized using `fromJS` in `reducers/accounts.js`, which created an
ImmutableJS `Record`, so let's use the proper type.
Copy link
Contributor

@takayamaki takayamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I had overlooked this type of definition.
Thank you!

@renchap renchap requested a review from ClearlyClaire May 3, 2023 11:12
@ClearlyClaire ClearlyClaire merged commit 9a52a7f into mastodon:main May 3, 2023
23 checks passed
michealmikeyb pushed a commit to michealmikeyb/mastodon that referenced this pull request May 3, 2023
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants