Refactor Trends::Query to avoid brakeman sql injection warnings
#25881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
added
refactoring
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
brakeman-trends-query
branch
from
077d0fa
to
2336468
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
brakeman-trends-query
branch
from
2336468
to
f9dbce3
Compare
ClearlyClaire
previously approved these changes
Jul 12, 2023
ClearlyClaire
requested changes
Jul 12, 2023
app/models/trends/query.rb
Outdated
| tmp_ids = ids | ||
|
|
||
| if tmp_ids.empty? | ||
| if ids.empty? |
There was a problem hiding this comment.
I would still use tmp_ids, as ids come from Redis and are not memoized.
There was a problem hiding this comment.
Updated with memoized method wrapping the redis call.
mjankowski
force-pushed
the
brakeman-trends-query
branch
from
f9dbce3
to
9517e30
Compare
ClearlyClaire
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query stays the same, avoids direct string interpolation in the query.