Upgrade to typescript-eslint v6
#25904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
added
dependencies
renchap
force-pushed
the
typescript-eslint-6
branch
from
87f233e
to
ebfc082
Compare
ykzts
approved these changes
Jul 11, 2023
|
This pull request has merge conflicts that must be resolved before it can be merged. |
renchap
force-pushed
the
typescript-eslint-6
branch
from
ebfc082
to
62496e2
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
Announcement and upgrade notes: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/ I used the recommended strict configs. I first auto-fixed what was possible. Then I applied the [`prefer-nullish-coalescing`](https://typescript-eslint.io/rules/prefer-nullish-coalescing) changes. Some were a good suggestion, others were not (we want to match an empty string) so I disabled the rule for those to make it explicit.
renchap
force-pushed
the
typescript-eslint-6
branch
from
d66bbfa
to
33397e7
Compare
ClearlyClaire
approved these changes
Jul 13, 2023
jsgoldstein
pushed a commit
to jsgoldstein/mastodon
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcement and upgrade notes: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/
I used the recommended strict configs.
I first auto-fixed what was possible.
Then I applied the
prefer-nullish-coalescingchanges.Some were a good suggestion, others were not (we want to match an empty string) so I disabled the rule for those to make it explicit.