Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for advanced web interface will be ignored while opening a profile directly by URL #26230

Closed
Der-K-2000 opened this issue Jul 28, 2023 · 7 comments
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged

Comments

@Der-K-2000
Copy link

Steps to reproduce the problem

Open* the long URL to open an user profile**, e. g.

(* In the case the own account is also registered at mastodon.social and you're logged-in)

(** It doesn't matter, if it's an internal or external profile.)

Expected behaviour

user will be opened in the very right column of the advanced web interface

Actual behaviour

the opposite behavior: single column

Detailed description

Even though the "advanced web interface" (→ /settings/preferences/appearance) is activated, long URLs to a profile will redirect to the single-column-version of mastodon. Especially outside the fediverse the regular link (e. g. https://mastodon.social/@Gargron) is used. If you're on the same server it irritates and it's not user friendly. Yes, I'm aware of the new link structure with /deck.

So my suggestion is to redirect to /deck/@user,

  1. if you're logged-in
  2. if you've activated the checkbox for the extended web interface and
  3. if you open a user profile (https://mastodon.social/@Gargron)

Mastodon instance

mastodon.social

Mastodon version

v4.1.5+nightly-2023-07-26

Browser name and version

x

Operating system

x

Technical details

No response

@Der-K-2000 Der-K-2000 added area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged labels Jul 28, 2023
@renchap
Copy link
Sponsor Member

renchap commented Jul 28, 2023

This is the new expected behaviour after #25893

You have a button under the logo to switch to the advanced interface.

image

There is a PR to improve this button: #26019

@Der-K-2000
Copy link
Author

Yes, as I wrote, I'm aware about this, but it's still not user friendly. My pitch was to open a user profile link in the advanced web interface, IF (!) it's already activated in the settings.

@Signez
Copy link
Sponsor Contributor

Signez commented Jul 29, 2023

Hey @Der-K-2000! The behaviour you are describing is exactly what is now expected. Indeed: it's feel even more user-hostile to reopen the whole advanced interface each time the user is opening something a new tab.

Did you have a workflow that is now broken since this change? (Let's note that "it wasn't like this before and I am not used to it" is not really the same as "it's not user friendly". I had several great feedbacks since we merged this change! So I'd prefer having your rationale to make it even better, instead of just rolling it back.)

@Der-K-2000
Copy link
Author

I didn't want to start a pro/con discussion. Certainly there are good arguments for one side or the other. My main point is that this behaviour should be done in the user settings. Currently, the existing setting is ignored and, well, yes, that workflow is now broken. And finally that isn't user-friendly.

@Signez
Copy link
Sponsor Contributor

Signez commented Jul 29, 2023

The existing setting is not ignored: you will we redirected to the advanced interface only if you have enabled it, and the "Open in the advanced interface" button in the single column interface will only show up if you have enabled it.

Let's also note that the preference is not "Always open in the advanced interface", it's just "Enable the advanced interface", so I do think that user preferences are respected.

You still didn't answer on how that break your workflow, i.e. why are you expecting the advanced interface to open each time you open a link in a new tab or window? I am genuinely interested, as I am working into improving the advanced interface further.

@Der-K-2000
Copy link
Author

The existing setting is not ignored: you will we redirected to the advanced interface only if you have enabled it, and the "Open in the advanced interface" button in the single column interface will only show up if you have enabled it.

Nope, it's not. That's why I started this. Opening https://mastodon.social/@Gargron will not redirect to the advanced interface (→ https://mastodon.social/deck/@Gargron). It's the single column.

Let's also note that the preference is not "Always open in the advanced interface", it's just "Enable the advanced interface", so I do think that user preferences are respected.

Right. But I think it implicates that. At least it not that clear as we might think.

You still didn't answer on how that break your workflow, i.e. why are you expecting the advanced interface to open each time you open a link in a new tab or window? I am genuinely interested, as I am working into improving the advanced interface further.

If I click a user-link outside mastodon/fediverse, it will not open the advanced interface. So every time I have to click the button to get back to the web interface I want. And well, that happens more often than you can imagine.

When I open Open original page (via context menu) on a different instance, because I have more than one account/server, it will also open the single column version.

@Signez
Copy link
Sponsor Contributor

Signez commented Jul 29, 2023

Nope, it's not. That's why I started this. Opening https://mastodon.social/@Gargron will not redirect to the advanced interface (→ https://mastodon.social/deck/@Gargron). It's the single column.

Mea culpa, I didn't write it correctly in my reply; it redirects if you connect to home_paths, i.e. /, /home or /explore iirc. It's still won't help you, but I understood that from the start 😅

If I click a user-link outside mastodon/fediverse, it will not open the advanced interface. So every time I have to click the button to get back to the web interface I want. And well, that happens more often than you can imagine.
When I open Open original page (via context menu) on a different instance, because I have more than one account/server, it will also open the single column version.

Yes, that's a trade-off I had in mind when I implemented that feature, and I am sincerely sorry that you happen to be in the corner case that is annoying to you. (I think that it's a corner case, and you may disagree, but it doesn't mean we shouldn't think about it!)

To resolve this, there is multiple options:

  • Add another boolean preference to let you "force" the advanced interface booting up on every link on your home instance.
  • Revert our change and inject a ?from=deck query parameter to any link provided by the advanced interface, so links coming from elsewhere do start the advanced interface.
  • Revert our change and always open everything in the advanced interface, but of course, it's something I am not really for, as I suggested the change in the first place for good reasons :)

The second option (adding a query param to links) is a technological nightmare: it would pollute all links that would be shared, some links would go through anyway, and wasn't really what one of the core developer I talked with told me they wanted — as they had in mind to detach the whole advanced interface into its own URL anyway at some point, to maybe get rid of that preference in the long run.

The first option (adding a new preference) is the most straightforward, even if it's yet another preference setting, but it the most respectful for users like you that see value in always opening the advanced interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants