Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase React component spec coverage #2722

Closed
1 of 2 tasks
stephenburgess8 opened this issue May 2, 2017 · 6 comments
Closed
1 of 2 tasks

Increase React component spec coverage #2722

stephenburgess8 opened this issue May 2, 2017 · 6 comments

Comments

@stephenburgess8
Copy link
Contributor

stephenburgess8 commented May 2, 2017

The spec coverage on the React UI components is very limited. I propose that we add much more extensive UI spec coverage using enzyme, chai, mocha, and sinon. Things such as "When a user profile link is clicked, the user profile is shown on the page."

This task would be to go through the full set of React UI components, identify where specifications could describe the behavior on the page, and write tests to create much more comprehensive test coverage. I don't think it's necessary to add a spec coverage tool such as istanbul. Considering the large number of contributors to the project, having a much more extensive set of UI behavior specs would help increase confidence in PRs made from the general public.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@mjankowski
Copy link
Contributor

Yes, please do this. PRs adding coverage will be warmly embraced.

@Gargron
Copy link
Member

Gargron commented May 2, 2017

I suggest waiting until #2617 is merged to avoid lots of merge conflicts.

@stephenburgess8
Copy link
Contributor Author

Thanks @Gargron . I will watch that PR

@ashfurrow
Copy link
Contributor

No pressure at all @stephenburgess8 but #2617 has been merged 🌟

@stephenburgess8
Copy link
Contributor Author

Thanks. I couldn't get Mastodon to run locally a couple of days ago when I tried last. Will try again tonight.

@stephenburgess8
Copy link
Contributor Author

I never found time to do this, I apologize. Adding unit tests after components are built is very difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants