New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase React component spec coverage #2722
Comments
Yes, please do this. PRs adding coverage will be warmly embraced. |
I suggest waiting until #2617 is merged to avoid lots of merge conflicts. |
Thanks @Gargron . I will watch that PR |
No pressure at all @stephenburgess8 but #2617 has been merged 🌟 |
Thanks. I couldn't get Mastodon to run locally a couple of days ago when I tried last. Will try again tonight. |
I never found time to do this, I apologize. Adding unit tests after components are built is very difficult. |
The spec coverage on the React UI components is very limited. I propose that we add much more extensive UI spec coverage using enzyme, chai, mocha, and sinon. Things such as "When a user profile link is clicked, the user profile is shown on the page."
This task would be to go through the full set of React UI components, identify where specifications could describe the behavior on the page, and write tests to create much more comprehensive test coverage. I don't think it's necessary to add a spec coverage tool such as istanbul. Considering the large number of contributors to the project, having a much more extensive set of UI behavior specs would help increase confidence in PRs made from the general public.
master
(If you're a user, don't worry about this).The text was updated successfully, but these errors were encountered: