-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc spec/refactor to user mailer and user mailer spec #27486
Merged
ClearlyClaire
merged 10 commits into
mastodon:main
from
mjankowski:mailer-user-params-only-specs
Oct 27, 2023
Merged
Misc spec/refactor to user mailer and user mailer spec #27486
ClearlyClaire
merged 10 commits into
mastodon:main
from
mjankowski:mailer-user-params-only-specs
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original PR was missing a few things ... added them back, should fix CI. |
renchap
added
testing
Automated lint and test suites
refactoring
Improving code quality
ruby
Pull requests that update Ruby code
labels
Oct 21, 2023
ClearlyClaire
approved these changes
Oct 23, 2023
ponapalt
pushed a commit
to ponapalt/mastodon
that referenced
this pull request
Oct 29, 2023
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Oct 30, 2023
audiodude
pushed a commit
to audiodude/mastodon
that referenced
this pull request
Nov 16, 2023
000hen
pushed a commit
to thenapnetwork/nap-mastodon
that referenced
this pull request
Dec 6, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactoring
Improving code quality
ruby
Pull requests that update Ruby code
testing
Automated lint and test suites
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes from #25884 but without the parameterization changes that would break the method signatures for sidekiq queue concerns.