Add zeitwerk inflector for cli->CLI #27635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another alternate approach on this one specifically is to add it to the existing acronyms in the inflections file, in which case it would be use by rails more generally and not just the zeitwerk loader. |
Yeah, I was going to suggest that. |
mjankowski
force-pushed
the
rails-zeitwerk-locations-zeitwerk-inflector
branch
from
c34a750
to
5394c44
Compare
|
Updated to just add |
ClearlyClaire
approved these changes
Nov 30, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #27556
Pre-requisite for getting the autoload_lib feature enabled. This one tells zeitwerk to expect
CLIinstead ofCliin ourlib/mastodon/cli/*classes. We could alternately move the files to ac_l_idir, or rename the module toCli, but those feel worse than this mapping update.