Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite markers reducer in Typescript #27644

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

renchap
Copy link
Sponsor Member

@renchap renchap commented Oct 31, 2023

The actions are not trivial because there are a few ways to invoke them. There is a standard way, a debounced way, and a "sync" way tries tried various methods, in case someone closes the tab before the request is received?

I think we could simplify this and have it all done in the same action, but I chose to not change too many things in this PR.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (86500e3) to head (5356046).
Report is 415 commits behind head on main.

❗ Current head 5356046 differs from pull request most recent head 9b3162e. Consider uploading reports for the commit 9b3162e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27644      +/-   ##
==========================================
- Coverage   85.01%   82.70%   -2.32%     
==========================================
  Files        1059     1030      -29     
  Lines       28277    28152     -125     
  Branches     4538     4550      +12     
==========================================
- Hits        24040    23283     -757     
- Misses       3074     3786     +712     
+ Partials     1163     1083      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 27, 2024
Merged via the queue into mastodon:main with commit 27d014a Mar 27, 2024
34 checks passed
renchap added a commit to renchap/mastodon that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants