Rewrite PIP state in Typescript #27645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
force-pushed
the
ts-pip
branch
5 times, most recently
from
615ac66
to
658cae4
Compare
ClearlyClaire
requested changes
Nov 24, 2023
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27645 +/- ##
==========================================
- Coverage 85.01% 82.70% -2.32%
==========================================
Files 1059 1030 -29
Lines 28277 28152 -125
Branches 4538 4550 +12
==========================================
- Hits 24040 23283 -757
- Misses 3074 3786 +712
+ Partials 1163 1083 -80 ☔ View full report in Codecov by Sentry. |
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
ClearlyClaire
requested changes
Mar 27, 2024
|
This pull request has resolved merge conflicts and is ready for review. |
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
ClearlyClaire
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 1:1 rewrite in Typescript, including the only consuming component.
The state is now a plain JS object, fully typed.