File cleanup/organization in controllers/concerns
#27846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
added
refactoring
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
api-concerns
branch
from
8f86f6c
to
d9d3f75
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
api-concerns
branch
from
d9d3f75
to
bd82ea7
Compare
mjankowski
force-pushed
the
api-concerns
branch
from
bd82ea7
to
a59526c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27846 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 1030 1030
Lines 28145 28145
Branches 4549 4549
=======================================
Hits 23270 23270
Misses 3788 3788
Partials 1087 1087 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Nov 30, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few of the controller concerns were only used in the API area, and was going to move them into an
Api::namespace. Once I started that I noticed a similar dynamic with someSettings::andAuth::andAdmin::concerns as well.This is just a file/module move to stop
concernsfrom becoming junk drawer; should not be behavior change.There may be room for similar org/cleanup in the models concerns, since many of those are only used in one spot. Will do that next if we like this.