Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from 48px weight 600 material symbol icons to 24px weight 400 icons #28064

Merged
merged 6 commits into from Jan 12, 2024

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Nov 24, 2023

Before

image

After

image

EDIT: switched to 24×24px icons rather than 20×20px

@ClearlyClaire ClearlyClaire changed the title Features/download material icons Switch from 48px weight 600 material symbol icons to 20px weight 400 icons Nov 24, 2023
@ClearlyClaire
Copy link
Contributor Author

They look too small, now :/

@ClearlyClaire ClearlyClaire force-pushed the features/download-material-icons branch 5 times, most recently from 62275ac to fc73229 Compare November 24, 2023 14:21
@ClearlyClaire
Copy link
Contributor Author

Using weight 400, 24×24px icons with the size adjustments from #27924, icons would look like this:

image

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@ClearlyClaire ClearlyClaire changed the title Switch from 48px weight 600 material symbol icons to 20px weight 400 icons Switch from 48px weight 600 material symbol icons to 24px weight 400 icons Dec 7, 2023
@ClearlyClaire ClearlyClaire marked this pull request as ready for review December 7, 2023 14:14
@ClearlyClaire ClearlyClaire force-pushed the features/download-material-icons branch from 7e00868 to 3a13115 Compare December 7, 2023 14:15
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@ClearlyClaire ClearlyClaire force-pushed the features/download-material-icons branch from b94391d to 0ade213 Compare January 12, 2024 10:59
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

Using the following command:
`find app/javascript/ -name '*.[tj]s*' -exec sed -i "s:from '@material-symbols/svg-600/outlined:from 'mastodon/../material-icons/400-20px:g" {} \;`
@ClearlyClaire ClearlyClaire force-pushed the features/download-material-icons branch from 0ade213 to d890a07 Compare January 12, 2024 11:38
@Gargron Gargron added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 6bbcd93 Jan 12, 2024
48 checks passed
@Gargron Gargron deleted the features/download-material-icons branch January 12, 2024 20:22
mjankowski pushed a commit to mjankowski/mastodon that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants