Change preview card deletes to be done using batch method #28183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28183 +/- ##
==========================================
- Coverage 82.83% 82.83% -0.01%
==========================================
Files 1038 1038
Lines 28222 28221 -1
Branches 4550 4550
==========================================
- Hits 23377 23376 -1
Misses 3756 3756
Partials 1089 1089 ☔ View full report in Codecov by Sentry. |
Gargron
approved these changes
Dec 1, 2023
ClearlyClaire
approved these changes
Dec 4, 2023
|
Agreed, I just didn't want to tie it up as part of the same PR. |
|
Since the retry handling has now merged is this OK to go too? |
vmstan
added a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
added a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
smiba
pushed a commit
to smiba/mastodon
that referenced
this pull request
Jan 10, 2024
smiba
pushed a commit
to smiba/mastodon
that referenced
this pull request
Jan 24, 2024
smiba
pushed a commit
to smiba/mastodon
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes preview card deletion to utilize batch deletion method introduced in #23302