Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2x double subject call in models/form/account_batch spec #28209

Conversation

mjankowski
Copy link
Contributor

Basically two changes here:

  • Both of these context sections were running subject twice in order to assert different things against the results - combined these into one example for each context
  • They had some repeated change/finder code because they are doing basically the same assertions, pulled those into private methods.

@renchap renchap added testing Automated lint and test suites ruby Pull requests that update Ruby code labels Dec 4, 2023
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Dec 4, 2023
Merged via the queue into mastodon:main with commit 89a8e6e Dec 4, 2023
32 checks passed
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Dec 14, 2023
@mjankowski mjankowski deleted the chained-change-in-form-account-batch-spec branch December 22, 2023 15:23
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code testing Automated lint and test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants