Clean up tagged_with_*
Status specs, fix RSpec/LetSetup
cop
#28462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here is a pure refactor -- changing what had been a reorder/pluck/uniq setup asserting against a contain_exactly, to just use include against the non-order-determined collection. This seems fine to me since there's no order spec'd in the code.
The second commit makes use of previously unused vars in a way that I think is consistent with why they were present.