Fix Performance/StringIdentifierArgument cop
#28508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28508 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 1039 1039
Lines 28229 28229
Branches 4550 4550
=======================================
Hits 23880 23880
Misses 3197 3197
Partials 1152 1152 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed the bulk of these previously (#28399) - but the version bump - #28395 - had a false negative which missed the one changed in this PR. I believe with this merged, this will be fine after renovate rebase - #28492