Fix Capybara/ClickLinkOrButtonStyle cop in spec/features
#28576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28576 +/- ##
==========================================
- Coverage 84.78% 84.78% -0.01%
==========================================
Files 1039 1039
Lines 28250 28255 +5
Branches 4556 4556
==========================================
+ Hits 23952 23956 +4
Misses 3141 3141
- Partials 1157 1158 +1 ☔ View full report in Codecov by Sentry. |
mjankowski
force-pushed
the
capybara-rubocop-fix
branch
from
14bee16
to
722b516
Compare
ClearlyClaire
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve issues from https://github.com/mastodon/mastodon/actions/runs/7393217631/job/20112803890?pr=28571
(This change is a change of a previous default we had changed, and the cop may be removed in a future release. I personally think this style (more tolerant of underlying markup) is better, though)