Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "low risk" Rails 7.1 setting defaults #28626

Merged
merged 11 commits into from Jan 9, 2024

Conversation

mjankowski
Copy link
Contributor

I want to start working through this file and either enabling or figuring out a migration path for the various settings here.

This PR is the result of doing a quick scan through the file -- I turned on anything which either I was pretty sure is not relevant to the app, reflects a practice we already had in place, or just otherwise seemed low-risk/sensible change.

I stayed away from anything which I either know needs a migration path or more contemplation first. Hoping to work through those in separate PRs.

Once they're all enabled and we're convinced all is well, we can delete the file and toggle application.rb to 7.1 defaults.

@mjankowski
Copy link
Contributor Author

After the initial PR here I started making one-off branches for some additional setting changes, but realized that more of them were also pretty safe/boring, so pushed more commits here.

I (separately) also enabled the 7.1 defaults in application.rb, and the full spec suite passes with no warnings/deprecations/etc - so I think we're probably good from a narrow behavior perspective, and the only thing to sort out is migration paths.

I have left a few settings related to cache format changes, hash digest algorithms, marshalling formats, etc - unchanged for now - because I know there's separate discussion in misc other PRs about what changes to make there.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9322396) 84.78% compared to head (6059cf6) 84.77%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28626      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       28163    28162       -1     
  Branches     4541     4541              
==========================================
- Hits        23877    23875       -2     
- Misses       3128     3129       +1     
  Partials     1158     1158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Jan 9, 2024
Merged via the queue into mastodon:main with commit 4e02838 Jan 9, 2024
28 checks passed
@mjankowski mjankowski deleted the 7-1-defaults-not-relevant branch January 9, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants