Fix LineLength haml-lint in app/views/auth area
#28664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
previously approved these changes
Jan 9, 2024
mjankowski
force-pushed
the
haml-lint-wrap-line-length-only-auth-area
branch
from
501f5af
to
49ee441
Compare
|
These always need rebase b/c of the timestamp in the todo ... rebased this one after settings merged. Will have at least two more: one for media player, one for admin -- and will be prepared to revise/rebase as needed on those as well. |
|
This fails the YML linting step for some reason, now. |
mjankowski
force-pushed
the
haml-lint-wrap-line-length-only-auth-area
branch
from
49ee441
to
1606ea1
Compare
I did a regeneration of the todo during my rebase, so it never had the commit hook run to format the yaml (the generator creates double quote yaml, our linter/hook want single). Updated again, should pass this time. |
ClearlyClaire
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of #28655 but for the
authviews.This fixes the 2 remaining violations in this area -- and while I was in there I did a once-over in the auth dirs to look for things which were long-ish and will become violations when we reduce that number. I was not exhaustive there, but they are all in the same spirit as the ones which were violations.