Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the devise-two-factor advisory as we have rate limits in place #28733

Merged
merged 1 commit into from Jan 15, 2024
Merged

Ignore the devise-two-factor advisory as we have rate limits in place #28733

merged 1 commit into from Jan 15, 2024
+6 −0

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire ClearlyClaire requested a review from a team January 15, 2024 10:24
renchap
renchap requested changes Jan 15, 2024
View reviewed changes
Copy link
Sponsor Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining that we have rate-limits on those endpoints since 3.2.0, implemented the fix recommended by upstream?

@renchap renchap added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit e81c5c0 Jan 15, 2024
43 checks passed
@renchap renchap deleted the ignore-ratelimit-cve branch January 15, 2024 10:51
mjankowski pushed a commit to mjankowski/mastodon that referenced this pull request Jan 15, 2024
@ClearlyClaire @mjankowski
Ignore the devise-two-factor advisory as we have rate limits in place (…
d569731 
…mastodon#28733)
ClearlyClaire added a commit that referenced this pull request Jan 23, 2024
@ClearlyClaire
Ignore the devise-two-factor advisory as we have rate limits in place (…
f8cbe9b 
…#28733)
ClearlyClaire added a commit that referenced this pull request Jan 24, 2024
@ClearlyClaire
Ignore the devise-two-factor advisory as we have rate limits in place (…
0dde70d 
…#28733)
ClearlyClaire added a commit that referenced this pull request Jan 24, 2024
@ClearlyClaire
Ignore the devise-two-factor advisory as we have rate limits in place (…
9b1aebd 
…#28733)
ClearlyClaire added a commit that referenced this pull request Jan 24, 2024
@ClearlyClaire
Ignore the devise-two-factor advisory as we have rate limits in place (…
4eb98ef 
…#28733)
kmycode pushed a commit to kmycode/mastodon that referenced this pull request Jan 24, 2024
@ClearlyClaire @kmycode
Ignore the devise-two-factor advisory as we have rate limits in place (…
72367f6 
…mastodon#28733)
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 2, 2024
@ClearlyClaire @ttrace
Ignore the devise-two-factor advisory as we have rate limits in place (…
3a4c452 
…mastodon#28733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renchap renchap renchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClearlyClaire @renchap