Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and refactor User#confirm! to User#mark_email_as_confirmed! #28735

Merged
merged 2 commits into from Jan 15, 2024

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire ClearlyClaire added refactoring Improving code quality ruby Pull requests that update Ruby code labels Jan 15, 2024
@ClearlyClaire ClearlyClaire requested a review from a team January 15, 2024 12:24
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e81c5c0) 84.84% compared to head (8700aeb) 84.85%.
Report is 5 commits behind head on main.

Files Patch % Lines
app/models/concerns/user/omniauthable.rb 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28735      +/-   ##
==========================================
+ Coverage   84.84%   84.85%   +0.01%     
==========================================
  Files        1038     1038              
  Lines       28152    28152              
  Branches     4534     4529       -5     
==========================================
+ Hits        23886    23889       +3     
  Misses       3103     3103              
+ Partials     1163     1160       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 98b5f85 Jan 15, 2024
53 checks passed
@ClearlyClaire ClearlyClaire deleted the refactor/mark_email_as_confirmed branch January 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improving code quality ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants