Announcement reactions query spec improvement and refactor

[mjankowski]

In the previous coverage I added for this we do exercise both account-present and account-not-present paths -- but we didn't have an assertion about the difference between those paths (the value of the me column in the query). This adds that coverage, and a few other details in coverage to get more precise.

The method change mainly pulls both the starting scope and the sql out to private methods, and tightens up return values with tap. I verified in console logs that the preloader still runs correctly here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd53859) 84.85% compared to head (616535f) 84.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #28768   +/-   ##
=======================================
  Coverage   84.85%   84.86%           
=======================================
  Files        1038     1038           
  Lines       28162    28165    +3     
  Branches     4531     4531           
=======================================
+ Hits        23898    23902    +4     
  Misses       3103     3103           
+ Partials     1161     1160    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ClearlyClaire]

This makes the query slightly more readable, but the whole thing is still incredibly slow and probably needs to be dropped or rewritten (with changes in the database model) eventually.