Remove unused matches_domain scopes on Account, DomainAllow, DomainBlock
#28803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28803 +/- ##
=======================================
Coverage 85.03% 85.04%
=======================================
Files 1038 1038
Lines 28120 28117 -3
Branches 4531 4530 -1
=======================================
- Hits 23913 23911 -2
Misses 3047 3047
+ Partials 1160 1159 -1 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DomainBlock and DomainAllow were originally added to use in the InstanceFilter - 24552b5#diff-8da415cf19c82e1283b141675cf9aec67ff23d48aa6bf7e0b54f4fa06eaa4875R17
The Account one was also added to help with InstanceFilter - da77f65#diff-8da415cf19c82e1283b141675cf9aec67ff23d48aa6bf7e0b54f4fa06eaa4875R23
They were all replaced with a method directly on Instance - 216b85b#diff-8da415cf19c82e1283b141675cf9aec67ff23d48aa6bf7e0b54f4fa06eaa4875R34 - which is still in use (referenced in other recent PR: #28795 (comment) )
The spec for this scope was the only thing in the DomainAllow spec. Instead of deleting it, I added a basic validation spec (basically copied from DomainBlock spec).