Add Account.auditable scope, fix N+1 in admin/action_logs#index
#28812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28812 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 1038 1038
Lines 28123 28124 +1
Branches 4530 4530
=======================================
+ Hits 23926 23927 +1
Misses 3038 3038
Partials 1159 1159 ☔ View full report in Codecov by Sentry. |
Gargron
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change -- add an
auditablescope to Account which finds (distinct) accounts that haveAdmin::ActionLogrecords.While reviewing queries from usage here, I noticed an N+1 in the controller -- theres a loop of _action_log partial which call out to the account for each one. Added account to includes in the filter to fix the N+1 there.