Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing action logging to api/v1/admin/reports#update #29044

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

mjankowski
Copy link
Contributor

A few things here:

  • Add coverage for the previous actions in api/v1/admin/reports which were creating logs, to verify they are created
  • Add coverage for the non-api admin/reports controller along same line
  • Add (initially failing) coverage around the update action in api/v1/admin/reports
  • Add the log_action line to make that last spec pass

@ThisIsMissEm - is that what you were looking at?

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1726085) 85.00% compared to head (f8511eb) 85.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29044   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files        1058     1058           
  Lines       28281    28282    +1     
  Branches     4538     4538           
=======================================
+ Hits        24040    24041    +1     
  Misses       3078     3078           
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This looks good to me. Whilst it won't capture "what" changed, at least it'll capture that a certain user made that change, and when.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 6, 2024
Merged via the queue into mastodon:main with commit 4cf07ed Feb 6, 2024
28 checks passed
@mjankowski mjankowski deleted the missing-admin-log-action branch February 6, 2024 14:25
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants