Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common ThreadingHelper module for specs #29116

Merged
merged 2 commits into from Feb 7, 2024

Conversation

mjankowski
Copy link
Contributor

We have a bunch of specs with this same pattern of building an n-sized array of threads, waiting/joining them, running same code inside, asserting changes after.

This pulls out the thread setup/running portion of that pattern into reusable helper, and updates the relevant specs.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (86500e3) 85.01% compared to head (00ad2bf) 85.02%.
Report is 29 commits behind head on main.

Files Patch % Lines
app/controllers/api/v1/statuses_controller.rb 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29116   +/-   ##
=======================================
  Coverage   85.01%   85.02%           
=======================================
  Files        1059     1059           
  Lines       28277    28292   +15     
  Branches     4538     4535    -3     
=======================================
+ Hits        24040    24054   +14     
- Misses       3074     3075    +1     
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 7, 2024
Merged via the queue into mastodon:main with commit 95da28d Feb 7, 2024
28 checks passed
@mjankowski mjankowski deleted the shared-thread-spec-thing branch February 7, 2024 15:23
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants