Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Redis <6.2 #29123

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Feb 7, 2024

Note that this leaves the possibility of a race condition in which multiple second-factor authentication attempts are performed at the same time and all triggering a mail. This is relatively improbable, though, and would only result in (limited) spam, it would not allow an attacker to avoid sending the mail.

@ClearlyClaire ClearlyClaire changed the title Fix compatibility with Redis 4 Fix compatibility with Redis <6 Feb 7, 2024
@ClearlyClaire
Copy link
Contributor Author

cc @kmycode

@ClearlyClaire ClearlyClaire requested a review from a team February 7, 2024 10:26
@kmycode
Copy link
Contributor

kmycode commented Feb 7, 2024

Thanks, it works for me.

$ redis-server --version
Redis server v=6.0.16 sha=00000000:0 malloc=jemalloc-5.2.1 bits=64 build=a3fdef44459b3ad6

RAILS_ENV=test bundle exec rspec spec/features/oauth_spec.rb

@ClearlyClaire ClearlyClaire changed the title Fix compatibility with Redis <6 Fix compatibility with Redis <6.2 Feb 7, 2024
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit eeabf9a Feb 7, 2024
43 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/redis-4-compatibility branch February 7, 2024 11:57
@renchap
Copy link
Sponsor Member

renchap commented Feb 7, 2024

We will need to remember to revert this once we change our supported redis version

skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
@ClearlyClaire
Copy link
Contributor Author

It seems that we are again incompatible with Redis < 6.2 because of our Stoplight update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants