Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-to-end test for OCR in media uploads #29148

Merged
merged 1 commit into from Feb 8, 2024
Merged

Add end-to-end test for OCR in media uploads #29148

merged 1 commit into from Feb 8, 2024

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire
Copy link
Contributor Author

I am not actually sure where the 404 errors come from exactly. Is the server setup in the system specs not able to correctly serve media files? I'm also not sure why it shows text.png and not a randomly-generated one 🤔

@ClearlyClaire
Copy link
Contributor Author

I am not actually sure where the 404 errors come from exactly. Is the server setup in the system specs not able to correctly serve media files? I'm also not sure why it shows text.png and not a randomly-generated one 🤔

Found the reason, it's because we skip sidekiq processing by default.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review February 8, 2024 16:14
mjankowski
mjankowski reviewed Feb 8, 2024
View reviewed changes
spec/system/ocr_spec.rb Outdated Show resolved Hide resolved
mjankowski
mjankowski reviewed Feb 8, 2024
View reviewed changes
spec/system/ocr_spec.rb Outdated Show resolved Hide resolved
mjankowski
mjankowski approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@mjankowski mjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few style items, looks good overall though.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit ca8fbda Feb 8, 2024
49 checks passed
@ClearlyClaire ClearlyClaire deleted the tests/ocr-e2e-test branch February 8, 2024 19:19
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
@ClearlyClaire @skerit
Add end-to-end test for OCR in media uploads (mastodon#29148)
820fdd8
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
@ClearlyClaire @Ember-ruby
Add end-to-end test for OCR in media uploads (mastodon#29148)
bfa993e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjankowski mjankowski mjankowski approved these changes

@renchap renchap renchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClearlyClaire @mjankowski @renchap