Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce RSpec/MultipleExpectations in media_attachment spec #29228

Conversation

mjankowski
Copy link
Contributor

Requirement of #29223

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (86500e3) 85.01% compared to head (bd4bb79) 85.00%.
Report is 70 commits behind head on main.

Files Patch % Lines
app/lib/application_extension.rb 62.50% 3 Missing ⚠️
app/models/concerns/user/omniauthable.rb 85.00% 0 Missing and 3 partials ⚠️
app/controllers/api/v1/statuses_controller.rb 87.50% 0 Missing and 1 partial ⚠️
.../controllers/auth/omniauth_callbacks_controller.rb 66.66% 0 Missing and 1 partial ⚠️
app/controllers/auth/sessions_controller.rb 50.00% 0 Missing and 1 partial ⚠️
app/lib/signature_parser.rb 93.75% 0 Missing and 1 partial ⚠️
app/models/concerns/user/ldap_authenticable.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29228      +/-   ##
==========================================
- Coverage   85.01%   85.00%   -0.01%     
==========================================
  Files        1059     1060       +1     
  Lines       28277    28307      +30     
  Branches     4538     4539       +1     
==========================================
+ Hits        24040    24063      +23     
- Misses       3074     3078       +4     
- Partials     1163     1166       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 16, 2024
Merged via the queue into mastodon:main with commit bba488c Feb 16, 2024
28 checks passed
@mjankowski mjankowski deleted the lower-multiple-expectations-media-attachment branch February 16, 2024 13:14
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants