Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AccountSuggestions::Source subclasses default limit value to constant #29282

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

mjankowski
Copy link
Contributor

These all inherit from same base class and have same default value.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86500e3) 85.01% compared to head (de008aa) 85.01%.
Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29282      +/-   ##
==========================================
- Coverage   85.01%   85.01%   -0.01%     
==========================================
  Files        1059     1060       +1     
  Lines       28277    28315      +38     
  Branches     4538     4542       +4     
==========================================
+ Hits        24040    24072      +32     
- Misses       3074     3077       +3     
- Partials     1163     1166       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 20, 2024
Merged via the queue into mastodon:main with commit 0ef44ee Feb 20, 2024
28 checks passed
@mjankowski mjankowski deleted the suggestions-default-limit branch February 20, 2024 14:03
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants