Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic coverage for MoveService class #29301

Merged
merged 1 commit into from Feb 23, 2024

Conversation

mjankowski
Copy link
Contributor

Resolves #29295

@renchap renchap added testing Automated lint and test suites ruby Pull requests that update Ruby code labels Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86500e3) 85.01% compared to head (e065c92) 85.01%.
Report is 107 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29301   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files        1059     1060    +1     
  Lines       28277    28320   +43     
  Branches     4538     4542    +4     
=======================================
+ Hits        24040    24077   +37     
- Misses       3074     3077    +3     
- Partials     1163     1166    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, thanks for the speedy implementation!

@mjankowski
Copy link
Contributor Author

I noticed a bunch of other service classes that also only had incidental coverage and added some more of these in other PRs.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 23, 2024
Merged via the queue into mastodon:main with commit b0064dd Feb 23, 2024
34 checks passed
@mjankowski mjankowski deleted the spec-services-move branch February 23, 2024 12:50
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code testing Automated lint and test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing specs for MoveService
4 participants