Use shared form partial for admin/domain_blocks views
#29609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
admin-domain-blocks-form-partial
branch
2 times, most recently
from
cc31f2e
to
917116b
Compare
mjankowski
force-pushed
the
admin-domain-blocks-form-partial
branch
2 times, most recently
from
4ff837e
to
e9b301f
Compare
|
Pushed commit to restore legacy URL style, now just a form extraction to clean up repeated template markup. |
mjankowski
force-pushed
the
admin-domain-blocks-form-partial
branch
from
8eac8eb
to
28e0af8
Compare
ClearlyClaire
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These views had almost same exact form generation, so extract a partial.
The only difference was around the disabled/readonly properties in the edit view (we don't want to let the domain value be edited once the block is created). This is preserved by checking
persisted?so the edit view will mark them disabled/readonly but the new view will keep the field open.Also did same stuff with inner variable name and simple_form style as in #29608