Ensure case-insensitive fields are converted to lowercase in Admin Imports #29739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this meant that CSV files generated from Python would fail to import, since in python, booleans in CSV are output as either True or False. Additionally there's no difference between 'Suspend' and 'suspend', both should be handled the same.
ThisIsMissEm
added a commit
to ThisIsMissEm/mastodon
that referenced
this pull request
Mar 24, 2024
…orts This change is for the same reasons as mastodon#29739
mjankowski
approved these changes
Mar 25, 2024
ClearlyClaire
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code meant that CSV files generated from Python would fail to import, since in Python boolean values when output in CSV as either True or False, not "true" or "false" as Ruby expects.
Additionally there's no difference between 'Suspend' and 'suspend', both should be handled the same, and likewise, domains are case-insensitive.
This fixes #26253
There are currently no tests at all for Admin::Import, and adding them feels out of scope of this minor fix.