Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cocaine::ExitStatusError when upload small non-animated GIF #5489

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix Cocaine::ExitStatusError when upload small non-animated GIF #5489

merged 1 commit into from
Oct 26, 2017

Conversation

unarist
Copy link
Contributor

@unarist unarist commented Oct 20, 2017 •
edited 

web_1        | Cocaine::ExitStatusError (Command 'identify -format %n '/tmp/93486e24dec84a7fd84445213e01dc5520171019-440-a6qiln.gif'' returned 1. Expected 0
web_1        | Here is the command output: STDOUT:
web_1        |
web_1        |
web_1        |
web_1        | STDERR:
web_1        |
web_1        | identify: improper image header `/tmp/93486e24dec84a7fd84445213e01dc5520171019-440-a6qiln.gif' @ error/gif.c/ReadGIFImage/1009.
web_1        | ):
...

Looks like copied tempfile need to be flushed before further processing, or :small generation fails due to reading empty file. This issue won't happen if the uploaded file has enough file size.

@unarist
Fix Cocaine::ExitStatusError when upload small non-animated GIF
b1b01fe 
Looks like copied tempfile need to be flushed before further processing. This issue won't happen if the uploaded file has enough file size.
@unarist unarist added the bug Something isn't working label Oct 20, 2017
@unarist unarist merged commit 4f337c0 into mastodon:master Oct 26, 2017
@unarist unarist deleted the fix/non-anim-gif branch September 29, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unarist @ykzts