Handle missing URL scheme in base path correctly

besticon/besticon.go

@@ -326,6 +326,10 @@ func absoluteURL(baseURL *url.URL, path string) (string, error) {
 	}
 
 	url.Scheme = baseURL.Scheme
+	if url.Scheme == "" {
+		url.Scheme = "http"
+	}
+
 	if url.Host == "" {
 		url.Host = baseURL.Host
 	}
@@ -335,6 +339,10 @@ func absoluteURL(baseURL *url.URL, path string) (string, error) {
 func urlFromBase(baseURL *url.URL, path string) string {
 	url := *baseURL
 	url.Path = path
+	if url.Scheme == "" {
+		url.Scheme = "http"
+	}
+
 	return url.String()
 }
 

besticon/besticon_test.go

@@ -101,6 +101,17 @@ func TestEat24WithBaseTag(t *testing.T) {
 	assertEquals(t, expectedImages, actualImages)
 }
 
+func TestAlibabaWithBaseTagWithoutScheme(t *testing.T) {
+	actualImages, err := fetchIconsWithVCR("alibaba.vcr", "alibaba.com")
+	assertEquals(t, nil, err)
+	expectedImages := []Icon{
+		{URL: "http://is.alicdn.com/simg/single/icon/favicon.ico", Width: 16, Height: 16, Format: "ico", Bytes: 1406, Sha1sum: "4ffbef9b6044c62cd6c8b1ee0913ba93e6e80072"},
+		{URL: "http://www.alibaba.com/favicon.ico", Width: 16, Height: 16, Format: "ico", Bytes: 1406, Sha1sum: "4ffbef9b6044c62cd6c8b1ee0913ba93e6e80072"},
+	}
+
+	assertEquals(t, expectedImages, actualImages)
+}
+
 func TestARDWithSortBySize(t *testing.T) {
 	actualImages, err := fetchIconsWithVCR("ard.vcr", "ard.de")
 	assertEquals(t, nil, err)

vcr/vcr.go

@@ -104,6 +104,9 @@ func (t *recorderTransport) RoundTrip(r *http.Request) (*http.Response, error) {
 	defer t.mutex.Unlock()
 
 	resp, err := defaultTransport.RoundTrip(r)
+	if err != nil {
+		panic(err)
+	}
 
 	logRequest(t.writer, r)
 	logResponse(t.writer, resp, true)