Mark KQueue::Native#kevent as blocking with FFI #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interpreter lock. This prevents calls to KQueue::Queue#run from hanging the process.
mat813
added a commit
that referenced
this pull request
Feb 19, 2014
Mark KQueue::Native#kevent as blocking with FFI
|
Pushed 0.2.2 with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kevent is a blocking function and needs to be marked a such with FFI so it will release Ruby's global interpreter lock when calling it. Without this, calls to KQueue::Queue#run will hang the entire Ruby process, preventing other threads from running as well as preventing SIGINT/SIGTERM from being handled.