-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capybara helpers #7
Conversation
end | ||
|
||
def finished_all_ajax_requests? | ||
page.evaluate_script('jQuery.active').zero? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib/dekiru/capybara/helpers.rb
Outdated
page.execute_script(script) | ||
yield | ||
Timeout.timeout(::Capybara.default_max_wait_time) do | ||
loop until page.evaluate_script('window._capybaraModalWait').zero? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -0,0 +1,27 @@ | |||
module Dekiru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing frozen string literal comment.
lib/dekiru/capybara/helpers.rb
Outdated
module Dekiru | ||
module Capybara | ||
module Helpers | ||
def wait_for_bs_modal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait_for_eventとかの方が使い勝手良さそうな気も!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかにー
犬、やっぱりうざいな。 |
No description provided.