Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Remove all cut and sort references (Let's cut it out!) #119

Merged
merged 1 commit into from Nov 30, 2018
Merged

Remove all cut and sort references (Let's cut it out!) #119

merged 1 commit into from Nov 30, 2018

Conversation

matchai
Copy link
Owner

@matchai matchai commented Nov 30, 2018 •
edited

Description

Trim away the use of unnecessary GNU utilities for better compatibility across the board.

Motivation and Context

Closes #117

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

I have tested version.fish to ensure it still works after these changes 👍

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Let's cut it out!
0742825 
- Remove existing references to cut
- Remove unnecessary use of sort in git status

Co-authored-by: Snuggle <github@snuggi.es>
@matchai matchai requested a review from Snuggle November 30, 2018 00:59
@matchai matchai changed the title Let's cut it out! Remove all cut and sort references (Let's cut it out!) Nov 30, 2018
@Snuggle
Copy link
Collaborator

Snuggle commented Nov 30, 2018 •
edited

Hm, I wish there were some automated tests here! Just testing locally now.

[Edit] Huh, there was absolutely no need for sort? Sweet!

Snuggle
Snuggle approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@Snuggle Snuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, my git status isn't broken after messing around with it locally and better code! 🥂 ✨

@matchai
Copy link
Owner Author

matchai commented Nov 30, 2018

Cheers! 🥂
Thanks @gertcuykens for spotting this bug. Much appreciated! 😄

@matchai matchai merged commit e2a7d35 into master Nov 30, 2018
@matchai matchai deleted the replace-cut branch November 30, 2018 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Snuggle Snuggle Snuggle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows MSYS2: -uThe system cannot find the file specified.
2 participants
@matchai @Snuggle