refactor: strike and pattern to use overloads #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As nice as using the rest arguments would be, I decided to switch strike and pattern to use explicit overloads for up to 10 match arms. this choice was made because strike & pattern need to TELL match what type TIn is, to prevent having to explicitly tell each match arm what type it's matching on this change also simplifies the signatures of strike and pattern. While there are a lot, it should hopefully be easier to unpack.
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 102 103 +1
Branches 15 15
=========================================
+ Hits 102 103 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As nice as using the rest arguments would be, I decided to switch strike and pattern to use explicit overloads for up to 10 match arms.
this choice was made because strike & pattern need to TELL match what type TIn is, to prevent having to explicitly tell each match arm what type it's matching on
this change also simplifies the signatures of strike and pattern. While there are a lot, it should hopefully be easier to unpack.