Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: strike and pattern to use overloads #22

Merged
merged 2 commits into from
Apr 19, 2020
Merged

refactor: strike and pattern to use overloads #22

merged 2 commits into from
Apr 19, 2020

Commits on Apr 19, 2020

  1. refactor: strike and pattern to use overloads 

    As nice as using the rest arguments would be, I decided to switch strike and pattern to use explicit overloads for up to 10 match arms.

this choice was made because  strike & pattern need to TELL match what type TIn is, to prevent having to explicitly tell each match arm what type it's matching on

 this change also simplifies the signatures of strike and pattern. While there are a lot, it should hopefully be easier to unpack.
    @cakekindel
    cakekindel committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    559175f View commit details
    Browse the repository at this point in the history

  2. move overloads out of public

    @cakekindel
    cakekindel committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    18e342c View commit details
    Browse the repository at this point in the history