Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #117

Merged
merged 6 commits into from Aug 12, 2020
Merged

Fix build #117

merged 6 commits into from Aug 12, 2020

Conversation

florian-huber
Copy link
Collaborator

No description provided.

@florian-huber
Copy link
Collaborator Author

florian-huber commented Aug 11, 2020 •
edited

Running into some conda errors here when trying to fix #116 (limiting sphinx to <3.2.0 at least for now seems to fix it).
Any short hints on that @fdiblen or @sverhoeven ?
Error is:
ERROR conda.core.link:_execute(568): An error occurred while installing package 'conda-forge::archspec-0.1.1-pyh9f0ad1d_0'.

(seems to happen when it updates conda on windows)

@sverhoeven
Copy link
Member

Try to upgrade https://github.com/marketplace/actions/setup-miniconda action in .github/workflows/conda_build.yml to latest version (v1.6.0).

@florian-huber florian-huber changed the title Limit sphinx version to <3.2.0 Fix build Aug 11, 2020
@florian-huber florian-huber marked this pull request as ready for review August 11, 2020 19:53
@florian-huber
Copy link
Collaborator Author

Thanks a lot Stefan, changing the miniconda-version seems to fix it!

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sverhoeven
sverhoeven approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bad luck to have 2 dependency issues at the same time.

Build of branch on readthedocs fails due to latest sphinx installation after environment-dev.yml is installed. Sphinx 3.2.1 should be released next weekend. So build should work after that.

@florian-huber
Copy link
Collaborator Author

Thanks for reviewing.

@florian-huber florian-huber merged commit c61da71 into master Aug 12, 2020
@florian-huber florian-huber deleted the florian-huber-patch-1 branch August 12, 2020 07:03
@florian-huber florian-huber mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florian-huber @sverhoeven