Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smaller logo on readme #44

Merged
merged 1 commit into from May 25, 2020
Merged

smaller logo on readme #44

merged 1 commit into from May 25, 2020

Conversation

cwmeijer
Copy link
Collaborator

Also removed matchms header, as the logo IS the header.
Because image height is ignored by github while rendering rst (github/markup#295 from 2014), I'm using raw html to get the logo the size that I want.

Also removed matchms header, as the logo IS the header. 
Because image height is ignored by github while rendering rst (github/markup#295 from 2014), I'm using raw html to get the logo the size that I want.
@cwmeijer cwmeijer requested a review from sverhoeven May 25, 2020 08:41
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (@jspaaks and I) liked it.
💯

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice but I am a bit sad that HTML was needed.

@cwmeijer cwmeijer merged commit 5eeb10b into master May 25, 2020
@cwmeijer cwmeijer deleted the smaller-logo-patch branch May 25, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants