add solution #2328
add solution #2328
Conversation
src/makeCalculator.js
Outdated
| operate(action, number) { | ||
| this.result = action(this.result, number); |
There was a problem hiding this comment.
Consider using the arithmetic operators with the assignment operator for better code style. For example, this.result += number when the action is addition. Since operate is a generic method, you may need to adjust the add, subtract, multiply, divide methods to work with the current value of result directly.
src/makeCalculator.js
Outdated
| add: (a, b) => a + b, | ||
| subtract: (a, b) => a - b, | ||
| multiply: (a, b) => a * b, | ||
| divide: (a, b) => a / b, |
There was a problem hiding this comment.
Arrow functions should not be used for methods that will be using this from their containing object, because arrow functions do not have their own this context; they inherit this from the parent scope at the time they are defined. In this case, since the methods are using this.result in the operate method, they should be defined using the shorthand method syntax without the arrow function.
| multiply(num) { | ||
| this.result *= num; | ||
| }, | ||
| divide(num) { |
There was a problem hiding this comment.
Consider case with division to 0 and throw error in such case
No description provided.