everything is completed #2333
Open
everything is completed #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jul 18, 2024
| @@ -3,8 +3,35 @@ | |||
| /** | |||
| * @return {object} | |||
| */ | |||
|
|
|||
| // `add`, `subtract`, `multiply`, `divide`, `reset`, `operate` | |||
|
|
|||
| function makeCalculator() { | |||
There was a problem hiding this comment.
According to the naming convention in the checklist, if a function is named makeCalculator, it should return an object named calculator. Currently, the function returns an object without a specific name. Consider adjusting the code to follow this convention if it's required by your project's guidelines.
|
|
||
| return this; | ||
| }, | ||
| operate(operation, val) { |
There was a problem hiding this comment.
The operate method can be improved by directly invoking the passed operation on this.result with the provided value instead of using call. This would simplify the implementation and avoid the unnecessary use of this binding, which is not needed as the methods add, subtract, multiply, divide are already using this to refer to the calculator object.
VitaliyBondarenko1982
suggested changes
Jul 19, 2024
|
|
||
| return this; | ||
| }, | ||
| operate(operation, val) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.