get-time - TR #240
Open
get-time - TR #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvalenty
suggested changes
May 25, 2020
src/getTime.js
Outdated
Comment on lines
23
to
27
| if (time !== null) { | ||
| return time[2]; | ||
| }; | ||
|
|
||
| return ''; |
ogsevko
reviewed
May 26, 2020
src/getTime.js
Outdated
| @@ -20,11 +20,7 @@ | |||
| function getTime(str) { | |||
| const time = str.match(/(\D|^)((([2][0-3])|([0-1][0-9])):[0-5][0-9])(\D|$)/); | |||
There was a problem hiding this comment.
(\D|^) and (\D|$) match any non-numeric symbols before and after HH:MM. It's better to use \b
ogsevko
approved these changes
May 26, 2020
danheim
approved these changes
May 26, 2020
| // write code here | ||
| const time = str.match(/\b((([2][0-3])|([0-1][0-9])):[0-5][0-9])\b/); | ||
|
|
||
| return (time !== null) ? time[1] : ''; |
There was a problem hiding this comment.
Suggested change
| return (time !== null) ? time[1] : ''; | |
| return time !== null ? time[1] : ''; |
There was a problem hiding this comment.
Так, як на мене, зручніше.
Щоб виділити умову, від результатів
| @@ -18,7 +18,9 @@ | |||
| * @returns {string} - valid time | |||
| */ | |||
| function getTime(str) { | |||
| // write code here | |||
| const time = str.match(/\b((([2][0-3])|([0-1][0-9])):[0-5][0-9])\b/); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.