commit #824
Open
commit #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozhukhovsky
suggested changes
Jul 1, 2023
| contentFromFile.stream() | ||
| .map(PARSER_FILE::parseLine) | ||
| .forEach(transaction -> operationStrategyMap | ||
| .get(Operation.checkTypeOperation(transaction.getOperation())) |
There was a problem hiding this comment.
I would create an OperationStrategy class, which will just be responsible for the logic of obtaining a handler for the desired operation.
| @@ -0,0 +1,5 @@ | |||
| package core.basesyntax.service; | |||
|
|
|||
| public interface FruitService { | |||
There was a problem hiding this comment.
Suggested change
| public interface FruitService { | |
| public interface ReportService { |
| import java.util.Map; | ||
|
|
||
| public class FruitServiceImpl implements FruitService { | ||
|
|
| public class FruitServiceImpl implements FruitService { | ||
|
|
||
| @Override | ||
| public String getReport() { |
There was a problem hiding this comment.
Potentially, it's better not to use internal storage, so we're hardwired to the class and it can't be used for anything else. Processing in the same way, only take the map not from storage, but pass it as a parameter to the method, but when calling, pass it from storage.
| import java.util.List; | ||
|
|
||
| public class ReaderServiceImpl implements ReaderService { | ||
|
|
| } catch (IOException e) { | ||
| throw new RuntimeException("Can't read from file " + filePath); | ||
| } | ||
| return content; |
| import java.io.FileWriter; | ||
|
|
||
| public class WriterServiceImpl implements WriterService { | ||
|
|
| import core.basesyntax.dto.Transaction; | ||
|
|
||
| public class AddOperationHandler implements OperationHandler { | ||
|
|
| import core.basesyntax.dto.Transaction; | ||
|
|
||
| public class BalanceOperationHandler implements OperationHandler { | ||
|
|
| import core.basesyntax.dto.Transaction; | ||
|
|
||
| public class PurchaseOperationHandler implements OperationHandler { | ||
|
|
|
please check the new commit |
kozhukhovsky
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.