Remarks are taken into account #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remarks are taken into account |
vkryvytskyy
requested changes
Jun 8, 2021
src/style.css
Outdated
Comment on lines
24
to
30
| /* .field1 { | ||
| font: Avenir-Book; | ||
| } | ||
|
|
||
| .field2 { | ||
| font: Avenir-Heavy; | ||
| } */ |
src/style.css
Outdated
Comment on lines
1
to
17
| @font-face { | ||
| font-family: Avenir; | ||
| src: url(./fonts/avenir.ttc); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Avenir; | ||
| font-style: italic; | ||
| src: url(./fonts/Avenir-Book.ttf); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Avenir-Heavy; | ||
| font-style: italic; | ||
| font-weight: bold; | ||
| src: url(./fonts/Avenir-Heavy.ttf); | ||
| } |
There was a problem hiding this comment.
Щоб підключити 2 жирності одного шрифта потрібно вказати джерело шрифта, назву шрифта і його жирність.
@font-face {
font-family: Avenir;
src: url(/fonts/Avenir-Book.ttf);
font-weight: 300;
}
@font-face {
font-family: Avenir;
src: url(/fonts/Avenir-Heavy.ttf);
font-weight: 900;
}
|
New version |
vkryvytskyy
requested changes
Jun 16, 2021
Comment on lines
+3
to
+4
| - [DEMO LINK](https://RomanProkopiv.github.io/layout_search-bar-airbnb/) | ||
| - [TEST REPORT LINK](https://RomanProkopiv.github.io/layout_search-bar-airbnb/report/html_report/) |
There was a problem hiding this comment.
Ссылки не рабочие, выполни пунтк 15 отсюда
Comment on lines
+55
to
+57
| .search:default { | ||
| font-weight: 300; | ||
| } |
There was a problem hiding this comment.
Думаю это можно прописать просто в .search
Comment on lines
+29
to
+46
| .field1 { | ||
| height: 70px; | ||
| font-size: 15px; | ||
| background: url(./images/Search.svg) no-repeat scroll left center; | ||
| background-position-x: 23px; | ||
| padding-left: 60px; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .field2 { | ||
| height: 40px; | ||
| font-size: 13px; | ||
| background: url(./images/Search.svg) no-repeat scroll left center; | ||
| background-size: 12px; | ||
| background-position-x: 11px; | ||
| padding-left: 30px; | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
У нас є search та search--small (--small - модифікатор). Тому всі стилі які прописані для “великого” інпуту ми задаємо для всіх інпутів в цілому, а за допомогою модифіктора small міняємо тільки потрібні значення, щоб наш інпут став малим.
field1 и field2 очень непонятные классы
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.