Skip to content

Commit

Permalink
ev-sidebar-bookmarks: use NULL instead of uninitialized variable
Browse files Browse the repository at this point in the history 
follow-up to be5fadc
  • Loading branch information
@monsta
monsta committed May 14, 2018
1 parent 05e6aa3 commit 03a697c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions shell/ev-sidebar-bookmarks.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ ev_sidebar_bookmarks_popup_menu_show (EvSidebarBookmarks *sidebar_bookmarks,
EvSidebarBookmarksPrivate *priv = sidebar_bookmarks->priv;
GtkTreeView *tree_view = GTK_TREE_VIEW (sidebar_bookmarks->priv->tree_view);
GtkTreeSelection *selection = gtk_tree_view_get_selection (tree_view);
GdkEvent *event;

if (keyboard_mode) {
if (!gtk_tree_selection_get_selected (selection, NULL, NULL))
Expand All @@ -355,7 +354,7 @@ ev_sidebar_bookmarks_popup_menu_show (EvSidebarBookmarks *sidebar_bookmarks,
if (!priv->popup)
priv->popup = gtk_ui_manager_get_widget (priv->ui_manager, "/BookmarksPopup");

gtk_menu_popup_at_pointer (GTK_MENU (priv->popup), (const GdkEvent*) event);
gtk_menu_popup_at_pointer (GTK_MENU (priv->popup), NULL);
return TRUE;
}

Expand Down

2 comments on commit 03a697c

@raveit65
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem?

@monsta
Copy link
Contributor Author

@monsta monsta commented on 03a697c May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing uninitialized variable into gtk_menu_popup_at_pointer.

Please sign in to comment.