Skip to content
Browse files
ev-sidebar-bookmarks: use NULL instead of uninitialized variable
follow-up to be5fadc
  • Loading branch information
monsta committed May 14, 2018
1 parent 05e6aa3 commit 03a697c79b372ddd4cbfd0185b57ece4647d6319
Showing with 1 addition and 2 deletions.
  1. +1 −2 shell/ev-sidebar-bookmarks.c
@@ -331,7 +331,6 @@ ev_sidebar_bookmarks_popup_menu_show (EvSidebarBookmarks *sidebar_bookmarks,
EvSidebarBookmarksPrivate *priv = sidebar_bookmarks->priv;
GtkTreeView *tree_view = GTK_TREE_VIEW (sidebar_bookmarks->priv->tree_view);
GtkTreeSelection *selection = gtk_tree_view_get_selection (tree_view);
GdkEvent *event;

if (keyboard_mode) {
if (!gtk_tree_selection_get_selected (selection, NULL, NULL))
@@ -355,7 +354,7 @@ ev_sidebar_bookmarks_popup_menu_show (EvSidebarBookmarks *sidebar_bookmarks,
if (!priv->popup)
priv->popup = gtk_ui_manager_get_widget (priv->ui_manager, "/BookmarksPopup");

gtk_menu_popup_at_pointer (GTK_MENU (priv->popup), (const GdkEvent*) event);
gtk_menu_popup_at_pointer (GTK_MENU (priv->popup), NULL);
return TRUE;

2 comments on commit 03a697c


This comment has been minimized.

Copy link

@raveit65 raveit65 replied May 14, 2018

What was the problem?


This comment has been minimized.

Copy link
Member Author

@monsta monsta replied May 15, 2018

Passing uninitialized variable into gtk_menu_popup_at_pointer.

Please sign in to comment.