Make sure attachments window fills entire sidebar #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, long time ago that i've seen you :) |
raveit65
reviewed
Jul 26, 2020
shell/ev-sidebar-attachments.c
Outdated
| @@ -565,6 +565,7 @@ ev_sidebar_attachments_init (EvSidebarAttachments *ev_attachbar) | |||
| gtk_container_add (GTK_CONTAINER (swindow), | |||
| ev_attachbar->priv->icon_view); | |||
|
|
|||
| gtk_box_pack_start (GTK_BOX (ev_attachbar), swindow, TRUE, TRUE, 0); | |||
There was a problem hiding this comment.
Can you fix the indent please?
Sadly, the code uses tabs here (not our code-style), but you should do the same for one new line.
There was a problem hiding this comment.
OK, updated my tree, changed the spaces to tabs!
|
Attachments sidebar looks much better now. So only code-formatting needs to be fixed. |
|
A new warning message floods the system logs after merging this commit: |
|
Confirmed, should i revert the commit? |
|
if gtk_box_pack_start is used then gtk_container_add can be removed. diff --git a/shell/ev-sidebar-attachments.c b/shell/ev-sidebar-attachments.c
index 389d169..2bcaedb 100644
--- a/shell/ev-sidebar-attachments.c
+++ b/shell/ev-sidebar-attachments.c
@@ -566,8 +566,10 @@ ev_sidebar_attachments_init (EvSidebarAttachments *ev_attachbar)
ev_attachbar->priv->icon_view);
gtk_box_pack_start (GTK_BOX (ev_attachbar), swindow, TRUE, TRUE, 0);
+/*
gtk_container_add (GTK_CONTAINER (ev_attachbar),
swindow);
+*/
gtk_widget_show_all (GTK_WIDGET (ev_attachbar));
/* Icon Theme */test |
raveit65
added a commit
that referenced
this pull request
Aug 26, 2020
Fixes a runtime warning caused by 70f42da See #476 (comment) for more info.
|
PR #487 |
raveit65
added a commit
that referenced
this pull request
Aug 26, 2020
Fixes a runtime warning caused by 70f42da See #476 (comment) for more info.
rbuj
pushed a commit
that referenced
this pull request
Aug 28, 2020
Fixes a runtime warning caused by 70f42da See #476 (comment) for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at a document that has attachments, the attachment window only opens up a very small portion of the sidebar up at the top. Looking at the source code for another document viewer from another project cough evince cough I found you needed to have a call to gtk_box_pack_start () in order to have it fill out the sidebar. Here's a pull request that fixes the issue. Tested on Debian 10, works.