epub: Avoid crash when index list has extraneous entry #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukefromdc
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
A build with both this and
#604 applied on gcc-13 allowed epub-document.c to build with no warnings whatsoever. Runtime test on wayland we still get the opengl context unsupported error and close but that is shared with master and is something for another PR to handle. Earlier x11 test of the other PR showed we didn't have a fundamental underlying crasher as epubs stayed open in x11.
Will doublecheck this one too in my next x11 session but in my default mate-wayland session at the moment
cwendling
approved these changes
Jan 31, 2024
This commit also fixes an incorrect sizeof call detected by AddressSanitizer. Closes mate-desktop#599
raveit65
force-pushed
the
fix-epub-crash
branch
from
fd537b5
to
bf8e495
Compare
raveit65
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also fixes an incorrect
sizeofcall detected by AddressSanitizer.Closes #599
Testing