Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing GtkRadioButton id #117

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix missing GtkRadioButton id #117

merged 1 commit into from
Apr 28, 2023

Conversation

dahenry
Copy link
Contributor

@dahenry dahenry commented Nov 18, 2022

Add missing id to custom scale radio button referenced in caja-image-resizer.c This fixes issue #104.

Add missing id to custom scale radio button referenced in caja-image-resizer.c
This fixes issue #104.
@dahenry dahenry closed this by deleting the head repository Nov 18, 2022
@dahenry dahenry reopened this Nov 18, 2022
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, resizing an image now follows a selected scale option and did not before

@raveit65
Copy link
Member

Hmm, pulling the repo failed for some reasons.

[rave@mother caja]$ git checkout -b dahenry-patch-1 master
Switched to a new branch 'dahenry-patch-1'
[rave@mother caja]$ curl -L https://github.com/mate-desktop/caja-extensions/pull/117.patch | git am -3
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1198    0  1198    0     0   1355      0 --:--:-- --:--:-- --:--:--  3017
Applying: Fix missing GtkRadioButton id
error: sha1 information is lacking or useless (image-converter/caja-image-resize.ui).
error: could not build fake ancestor
Patch failed at 0001 Fix missing GtkRadioButton id
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Looks like broken hash sum. I never saw that in git before.

@raveit65
Copy link
Member

The repo is deleted https://github.com/dahenry?tab=repositories

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
this fixes the issue

@raveit65 raveit65 merged commit 9801ebc into mate-desktop:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants